linux-kernel - Re: [PATCH] drm/mcde: dsi: Fix a return value check in mcde_dsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1900157b-39fe-e6fe-6fe7-26053a32f507@web.de>
Date:   Tue, 28 Apr 2020 18:15:26 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] drm/mcde: dsi: Fix a return value check in
 mcde_dsi_bind()

> In case of error, the function of_drm_find_bridge() returns NULL pointer
> not ERR_PTR().

Such information is helpful.


> The IS_ERR() test in the return value check should be
> replaced with NULL test.

* Would you like to convert this description into an imperative wording?

* Please fix the patch subject according to a function name.

* How do you think about to add the tag “Fixes” to the commit message
  because of an adjustment for the error detection?

Regards,
Markus