linux-kernel - Re: [Linux-kernel-mentees] [PATCH v2 0/2] realtek ethernet : remove legacy power management callbacks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d33991cc-c219-dc27-7559-f30dd5f4aa0a@gmail.com>
Date:   Tue, 28 Apr 2020 19:54:12 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Vaibhav Gupta <vaibhavgupta40@...il.com>,
        Shannon Nelson <snelson@...sando.io>,
        Jakub Kicinski <kuba@...nel.org>,
        Martin Habets <mhabets@...arflare.com>,
        Vaibhav Gupta <vaibhav.varodek@...il.com>,
        netdev@...r.kernel.org, Bjorn Helgaas <helgaas@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, bjorn@...gaas.com,
        linux-kernel-mentees@...ts.linuxfoundation.org, rjw@...ysocki.net
Cc:     linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-pm@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2 0/2] realtek ethernet : remove
 legacy power management callbacks.

On 28.04.2020 16:43, Vaibhav Gupta wrote:
> The purpose of this patch series is to remove legacy power management callbacks
> from realtek ethernet drivers.
> 
> The callbacks performing suspend() and resume() operations are still calling
> pci_save_state(), pci_set_power_state(), etc. and handling the powermanagement
> themselves, which is not recommended.
> 
Did you test any of the changes? If not, then mention this at least.
A typical comment in the commit message would be "compile-tested only".

In addition the following should be changed.
[Linux-kernel-mentees] [PATCH v2 0/2]
Use
[PATCH net-next v2 0/2]
instead.

> The conversion requires the removal of the those function calls and change the
> callback definition accordingly.
> 
> Vaibhav Gupta (2):
>   realtek/8139too: Remove Legacy Power Management
>   realtek/8139cp: Remove Legacy Power Management
> 
>  drivers/net/ethernet/realtek/8139cp.c  | 25 +++++++------------------
>  drivers/net/ethernet/realtek/8139too.c | 26 +++++++-------------------
>  2 files changed, 14 insertions(+), 37 deletions(-)
>