[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKz_xw0nQL2t1a-ofosLVb72JwSAGXCea5wOuddstOMrULNygg@mail.gmail.com>
Date: Tue, 28 Apr 2020 14:42:50 +1000
From: Evan Benn <evanbenn@...omium.org>
To: Julius Werner <jwerner@...omium.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Xingyu Chen <xingyu.chen@...ogic.com>,
Anson Huang <Anson.Huang@....com>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Catalin Marinas <catalin.marinas@....com>,
"David S. Miller" <davem@...emloft.net>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Guenter Roeck <linux@...ck-us.net>,
Leonard Crestez <leonard.crestez@....com>,
Li Yang <leoyang.li@....com>,
Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
Olof Johansson <olof@...om.net>, Rob Herring <robh@...nel.org>,
Shawn Guo <shawnguo@...nel.org>,
Valentin Schneider <valentin.schneider@....com>,
Will Deacon <will@...nel.org>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>,
LINUX-WATCHDOG <linux-watchdog@...r.kernel.org>
Subject: Re: [PATCH v5 2/2] watchdog: Add new arm_smc_wdt watchdog driver
On Fri, Apr 24, 2020 at 8:17 AM Julius Werner <jwerner@...omium.org> wrote:
>
> > + err = of_property_read_u32(pdev->dev.of_node, "arm,smc-id",
> > + &smc_func_id);
> > + if (err < 0)
> > + return err;
> > + watchdog_set_drvdata(wdd, (void *)(uintptr_t)smc_func_id);
>
> Your device tree binding says there's a default and this is optional.
> I think you need to change the code so that that's actually true.
I think I have misunderstood the device tree json-schema spec.
My intention was for the device tree to fill in a default value in the dtb for
arm,smc-id if it was omitted in the dts. But now I see that does not seem to
happen, I cannot really find any documentation of `default`, so I will just put
a documentation string in instead and force the default in the driver.
Powered by blists - more mailing lists