linux-kernel - Re: [PATCH net v2 2/2] net: phy: DP83TC811: Fix WoL in config init to be disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d150900f-7a54-2ff2-00cb-6b40ea18c468@ti.com>
Date:   Tue, 28 Apr 2020 15:59:01 -0500
From:   Dan Murphy <dmurphy@...com>
To:     David Miller <davem@...emloft.net>
CC:     <andrew@...n.ch>, <f.fainelli@...il.com>, <hkallweit1@...il.com>,
        <linux@...linux.org.uk>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <afd@...com>
Subject: Re: [PATCH net v2 2/2] net: phy: DP83TC811: Fix WoL in config init to
 be disabled

David

On 4/28/20 3:05 PM, David Miller wrote:
> From: Dan Murphy <dmurphy@...com>
> Date: Mon, 27 Apr 2020 16:21:12 -0500
>
>> +		return phy_write_mmd(phydev, DP83822_DEVADDR,
>                                               ^^^^^^^^^^^^^^^^
>
> Please don't submit patches that have not even had a conversation with
> the compiler.
>
> This register define only exists in dp83822.c and you are trying to use
> it in dp83tc811.c
>
> If this doesn't compile, how did you do functional testing of this
> change?

My fault, I thought my defconfig had this turned on to compile as it did 
in v1.

I functionally tested these changes on the DP83822 as they are register 
and feature compatible for WoL

Dan

> If you compile tested these changes against a tree other than the 'net'
> tree, please don't do that.
>
> Thanks.