linux-kernel - Re: [PATCH] net/x25: Fix null-ptr-deref in x25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200428.141111.54288142814578996.davem@davemloft.net>
Date:   Tue, 28 Apr 2020 14:11:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     andrew.hendry@...il.com, kuba@...nel.org, allison@...utok.net,
        tglx@...utronix.de, gregkh@...uxfoundation.org,
        tanxin.ctf@...il.com, xiyuyang19@...an.edu.cn,
        linux-x25@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/x25: Fix null-ptr-deref in x25_disconnect

From: YueHaibing <yuehaibing@...wei.com>
Date: Tue, 28 Apr 2020 16:12:08 +0800

> We should check null before do x25_neigh_put in x25_disconnect,
> otherwise may cause null-ptr-deref like this:
...
> Reported-by: syzbot+6db548b615e5aeefdce2@...kaller.appspotmail.com
> Fixes: 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.