linux-kernel - Re: [PATCH AUTOSEL 5.4 38/78] nvme: fix compat address handling in several ioctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADyTPEyHmxwskNAru-6asz-YYQZnzkMwJ1Rp1pFK+a8QHDRacQ@mail.gmail.com>
Date:   Tue, 28 Apr 2020 01:23:46 -0400
From:   Nick Bowler <nbowler@...conx.ca>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Sasha Levin <sashal@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux- stable <stable@...r.kernel.org>,
        Christoph Hellwig <hch@....de>, linux-nvme@...ts.infradead.org,
        lkft-triage@...ts.linaro.org, Basil Eljuse <Basil.Eljuse@....com>
Subject: Re: [PATCH AUTOSEL 5.4 38/78] nvme: fix compat address handling in
 several ioctls

On 2020-04-28, Naresh Kamboju <naresh.kamboju@...aro.org> wrote:
> On Sat, 18 Apr 2020 at 20:24, Sasha Levin <sashal@...nel.org> wrote:
>> From: Nick Bowler <nbowler@...conx.ca>
>>
>> [ Upstream commit c95b708d5fa65b4e51f088ee077d127fd5a57b70 ]
[...]
>> +static void __user *nvme_to_user_ptr(uintptr_t ptrval)
>> +{
>> +       if (in_compat_syscall())
>> +               ptrval = (compat_uptr_t)ptrval;
>
> arm64 make modules failed while building with an extra kernel config.
[...]
> 72 ../drivers/nvme/host/core.c:1256:13: error: ‘compat_uptr_t’
> undeclared (first use in this function); did you mean ‘compat_time_t’?

Probably commit 556d687a4ccd5 ("compat: ARM64: always include
asm-generic/compat.h") is required to be backported to 5.4 as a
prerequisite for including this fix in the 5.4 stable series.

Cheers,
  Nick