linux-kernel - Re: [PATCH 1/2] selftests/vDSO: prevent SIGFPE if vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Apr 2020 08:20:53 +0200
From:   Sven Schnelle <svens@...ux.ibm.com>
To:     Shuah Khan <shuah@...nel.org>
Cc:     svens@...ckframe.org, Thomas Gleixner <tglx@...utronix.de>,
        Steve Winslow <swinslow@...il.com>,
        Alexios Zavras <alexios.zavras@...el.com>,
        Allison Randal <allison@...utok.net>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] selftests/vDSO: prevent SIGFPE if vdso_info.nbucket
 is zero

On Sat, Apr 04, 2020 at 10:37:03PM +0200, Sven Schnelle wrote:
> If vdso_info can't be parsed correctly, vdso_info.nbucket might
> contain zero. Add a check and return NULL which will fail the
> symbol lookup.

Ping?

> 
> Signed-off-by: Sven Schnelle <svens@...ux.ibm.com>
> ---
>  tools/testing/selftests/vDSO/parse_vdso.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/vDSO/parse_vdso.c b/tools/testing/selftests/vDSO/parse_vdso.c
> index 1dbb4b87268f..8e5a70a24d9a 100644
> --- a/tools/testing/selftests/vDSO/parse_vdso.c
> +++ b/tools/testing/selftests/vDSO/parse_vdso.c
> @@ -226,6 +226,9 @@ void *vdso_sym(const char *version, const char *name)
>  		return 0;
>  
>  	ver_hash = elf_hash(version);
> +	if (!vdso_info.nbucket)
> +		return NULL;
> +
>  	ELF(Word) chain = vdso_info.bucket[elf_hash(name) % vdso_info.nbucket];
>  
>  	for (; chain != STN_UNDEF; chain = vdso_info.chain[chain]) {
> -- 
> 2.17.1
>