linux-kernel - Re: [PATCH] arm64: dts: allwinner: h6: Use dedicated CPU OPP table for Tanix TX6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJiuCcdnGW+jC8NQPWaE_fSEaNfrCcLhkmy3-L-ZXQmgQdsEKw@mail.gmail.com>
Date:   Tue, 28 Apr 2020 10:45:26 +0200
From:   Clément Péron <peron.clem@...il.com>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-sunxi <linux-sunxi@...glegroups.com>,
        Piotr Oniszczuk <warpme@...pl>
Subject: Re: [PATCH] arm64: dts: allwinner: h6: Use dedicated CPU OPP table
 for Tanix TX6

Hi Maxime,

On Tue, 28 Apr 2020 at 09:52, Maxime Ripard <maxime@...no.tech> wrote:
>
> On Sun, Apr 26, 2020 at 02:17:09PM +0200, Clément Péron wrote:
> > Tanix TX6 has a fixed regulator. As DVFS is instructed to change
> > voltage to meet OPP table. The DVFS is not working as expected.
> >
> > Introduce a dedicated OPP Table where voltage are equals to
> > the fixed regulator.
> >
> > Reported-by: Piotr Oniszczuk <warpme@...pl>
> > Fixes: add1e27fb703 ("arm64: dts: allwinner: h6: Enable CPU opp tables for Tanix TX6")
> > Signed-off-by: Clément Péron <peron.clem@...il.com>
>
> I'm not really a big fan of duplicating the OPPs, since that would make an
> update of those very likely to be overlooked for that particular board (and
> since it's a board that not a lot of people have, it would be harder to notice
> too).
>
> IIRC, removing the cpu-supply property should work as well?
Yes it would works also the OPP will provide a dummy regulator.

But as it has been introduced and there is a cpu regulator in the real life.
I thought it was a bit a hack to just remove it but as you wish.

Regards,
Clement



>
> Maxime