[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200428094851.GE1476763@krava>
Date: Tue, 28 Apr 2020 11:48:51 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
Ingo Molnar <mingo@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Clark Williams <williams@...hat.com>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
Arnaldo Carvalho de Melo <acme@...hat.com>,
Adrian Hunter <adrian.hunter@...el.com>,
Song Liu <songliubraving@...com>
Subject: Re: [PATCH 4/7] perf bpf: Decouple creating the evlist from adding
the SB event
On Mon, Apr 27, 2020 at 06:19:32PM -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
>
> Renaming bpf_event__add_sb_event() to evlist__add_sb_event() and
> requiring that the evlist be allocated beforehand.
hum, this seems to be done in previous patch, maybe you
need to squash this with the previous one?
jirka
>
> This will allow using the same side band thread and evlist to be used
> for multiple purposes in addition to react to PERF_RECORD_BPF_EVENT soon
> after they are generated.
>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Song Liu <songliubraving@...com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
> tools/perf/util/bpf-event.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/bpf-event.h b/tools/perf/util/bpf-event.h
> index 2c7a50509659..68f315c3df5b 100644
> --- a/tools/perf/util/bpf-event.h
> +++ b/tools/perf/util/bpf-event.h
> @@ -45,7 +45,7 @@ static inline int machine__process_bpf(struct machine *machine __maybe_unused,
> return 0;
> }
>
> -static inline int evlist__add_bpf_sb_event(struct evlist **evlist __maybe_unused,
> +static inline int evlist__add_bpf_sb_event(struct evlist *evlist __maybe_unused,
> struct perf_env *env __maybe_unused)
> {
> return 0;
> --
> 2.21.1
>
Powered by blists - more mailing lists