linux-kernel - Re: [PATCH] pinctrl: nomadik: db8500: remove some unused symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaH1bet-iBxB7pM9-_swpXkuUiMeg6jwTyx2j8WiB2G_g@mail.gmail.com>
Date:   Tue, 28 Apr 2020 11:56:25 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     Stephan Gerhold <stephan@...hold.net>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] pinctrl: nomadik: db8500: remove some unused symbols

On Fri, Apr 17, 2020 at 9:08 AM Jason Yan <yanaijie@...wei.com> wrote:

> Fix the following gcc warning:
>
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:899:20: warning:
> ‘sbag_groups’ defined but not used [-Wunused-const-variable=]
>  DB8500_FUNC_GROUPS(sbag, "sbag_oc2_1", "sbag_oc4_1");
>                     ^
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:570:23: warning:
> ‘ipgpio6_c_2_pins’ defined but not used [-Wunused-const-variable=]
>  static const unsigned ipgpio6_c_2_pins[] = { DB8500_PIN_G3 };
>                        ^~~~~~~~~~~~~~~~
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:472:23: warning:
> ‘mc1dir_a_1_pins’ defined but not used [-Wunused-const-variable=]
>  static const unsigned mc1dir_a_1_pins[] = { DB8500_PIN_AH13,
> DB8500_PIN_AG12,
>                        ^~~~~~~~~~~~~~~
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:453:23: warning:
> ‘modem_a_1_pins’ defined but not used [-Wunused-const-variable=]
>  static const unsigned modem_a_1_pins[] = { DB8500_PIN_D22,
> DB8500_PIN_C23,
>                        ^~~~~~~~~~~~~~
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:430:23: warning:
> ‘kpskaskb_a_1_pins’ defined but not used [-Wunused-const-variable=]
>  static const unsigned kpskaskb_a_1_pins[] = { DB8500_PIN_D17,
> DB8500_PIN_D16 };
>                        ^~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

These should not be deleted but used properly. I've sent another
patch fixing the problem and adding you as Reported-by.

Yours,
Linus Walleij