[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200428103824.GF23963@kozik-lap>
Date: Tue, 28 Apr 2020 12:38:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jonathan Bakker <xc-racer2@...e.ca>
Cc: kgene@...nel.org, robh+dt@...nel.org,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/13] S5PV210 and Aries DTS improvements
On Sun, Apr 26, 2020 at 11:35:51AM -0700, Jonathan Bakker wrote:
> This patchset makes several improvements to Aries devices which are
> based on S5PV210. Several pulls on GPIOs were incorrect/not specified,
> sleep GPIO configurations have been added, and more devices have been
> added.
>
> Touching the common S5PV210 DTSI are the addition of the ADC node
> as well as fixes to the FIMC definitions and a sleep GPIO helper
> added.
>
> The patches have been tested on both a GT-i9000 as well as an
> SGH-T959P and both can now suspend/resume properly.
>
> Jonathan Bakker (12):
> arm: dts: s5pv210: Add helper define for sleep gpio config
> arm: dts: s5pv210: fascinate4g: Add sleep GPIO configuration
> arm: dts: s5pv210: galaxys: Add sleep GPIO configuration
> arm: dts: s5pv210: aries: Set keep-power-in-suspend for SDHCI1
> arm: dts: s5pv210: aries: Disable pulls on GPIO i2c adapters
> arm: dts: s5pv210: aries: Add support for more devices
> arm: dts: s5pv210: aries: Disable pull for vibrator ena GPIO
> arm: dts: s5pv210: Add an ADC node
> arm: dts: s5pv210: aries: Enable ADC node
> arm: dts: s5pv210: Assign clocks to MMC devices
> arm: dts: s5pv210: Correct FIMC definitions
> arm: dts: s5pv210: aries: Set MAX8998 GPIO pulls
>
> Paweł Chmiel (1):
> arm: dts: s5pv210: galaxys: Add si470x fmradio
Thanks for the patches, nice work!
I commented on some of them. The other look good but I will wait with
applying for v2. When resending everything, change the subject of each
patch to match subsystem, so:
ARM: dts: s5pv210:
Best regards,
Krzysztof
Powered by blists - more mailing lists