linux-kernel - Re: [PATCH] subsystem: Amplifier driver for TAS5805M,Texas instruments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200428113033.GE5677@sirena.org.uk>
Date:   Tue, 28 Apr 2020 12:30:33 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Leslie Hsia(夏邦進_Pegatron) 
        <Leslie_Hsia@...atroncorp.com>
Cc:     "knaack.h@....de" <knaack.h@....de>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hermes Hsieh(謝旻劭_Pegatron) 
        <Hermes_Hsieh@...atroncorp.com>,
        "jesse.sung@...onical.com" <jesse.sung@...onical.com>,
        "jic23@...nel.org" <jic23@...nel.org>
Subject: Re: [PATCH] subsystem: Amplifier driver for TAS5805M,Texas
 instruments

On Tue, Apr 28, 2020 at 10:43:18AM +0000, Leslie Hsia(夏邦進_Pegatron) wrote:
>   *   Author: Leslie Hsia
>   *   Amplifier driver for TAS5805M, initial the amplifier and set the sound parameter.
>   *   Signed-off-by: Leslie Hsia <Leslie_Hsia@...atroncorp.com<mailto:Leslie_Hsia@...atroncorp.com>>

Please follow the patch submission process that is described in
Documentation/process/submitting-patches.rst in the kernel source.  Take
a look at other submissions on the list and follow a similar process.
There also appear to be both IIO and ASoC drivers in there which is at
best a bit weird.

Having done a quick scan through your code it doesn't actually seem to
integrate with the subsystem at all (there's no
snd_soc_register_codec()) 

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)