linux-kernel - Re: [PATCH] pinctrl: remove unused 'pwm37

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Apr 2020 19:44:49 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>
CC:     Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] pinctrl: remove unused 'pwm37_pins'



在 2020/4/28 19:30, Manivannan Sadhasivam 写道:
> On Tue, Apr 28, 2020 at 11:58:01AM +0200, Linus Walleij wrote:
>> On Fri, Apr 17, 2020 at 10:54 AM Jason Yan <yanaijie@...wei.com> wrote:
>>
>>> Fix the following gcc warning:
>>>
>>> drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined
>>> but not used [-Wunused-const-variable=]
>>>   static const unsigned int pwm37_pins[] = { 110 };
>>>                             ^~~~~~~~~~
>>>
>>> Reported-by: Hulk Robot <hulkci@...wei.com>
>>> Signed-off-by: Jason Yan <yanaijie@...wei.com>
>>
>> I'm sceptic about this. I think PWM37 exists and just need to be
>> properly defined.
>>
>> Mani will know the right solution to this.
>>
> 
> Sorry for missing this thread before. The original patch didn't land in my
> inbox.
> 
> Anyway the issue is, pwm37 is not added to BM1880_PINCTRL_GRP. So the proper
> fix would be to add it.
> 
> Jason, will you be able to send a patch for adding it? Otherwise I'll do that.
> 

OK, I will send v2 soon.

Thanks,
Jason

> Thanks,
> Mani
> 
>> Yours,
>> Linus Walleij
>