[<prev] [next>] [day] [month] [year] [list]
Message-ID: <831bf548-a461-6160-f878-ee0f4c5c311b@web.de>
Date: Tue, 28 Apr 2020 14:48:38 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Raghavendra Rao Ananta <rananta@...eaurora.org>,
linuxppc-dev@...ts.ozlabs.org
Cc: linux-kernel@...r.kernel.org,
Andrew Melnychenko <andrew@...nix.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jslaby@...e.com>
Subject: Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open
> Hence, serialize hvc_open and check if tty->private_data is NULL before
> proceeding ahead.
How do you think about to add the tag “Fixes” because of adjustments
for the data synchronisation?
…
> +++ b/drivers/tty/hvc/hvc_console.c
…
@@ -384,6 +394,8 @@ static int hvc_open(struct tty_struct *tty, struct file * filp)
…
> +out:
> + mutex_unlock(&hvc_open_mutex);
> return rc;
> }
I suggest to use the label “unlock” instead.
Regards,
Markus
Powered by blists - more mailing lists