lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Apr 2020 15:54:26 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Christophe JAILLET <christophe.jaillet@...adoo.fr> Cc: okaya@...nel.org, agross@...nel.org, bjorn.andersson@...aro.org, vkoul@...nel.org, dan.j.williams@...el.com, linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org, dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] dmaengine: qcom_hidma: Simplify error handling path in hidma_probe On Mon, Apr 27, 2020 at 01:10:43PM +0200, Christophe JAILLET wrote: > There is no need to call 'hidma_debug_uninit()' in the error handling > path. 'hidma_debug_init()' has not been called yet. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > --- > drivers/dma/qcom/hidma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c > index 411f91fde734..87490e125bc3 100644 > --- a/drivers/dma/qcom/hidma.c > +++ b/drivers/dma/qcom/hidma.c > @@ -897,7 +897,6 @@ static int hidma_probe(struct platform_device *pdev) > if (msi) ^^^ This test doesn't work. It will call free hidma_free_msis() if the hidma_request_msi() call fails. We should do: if (msi) { rc = hidma_request_msi(dmadev, pdev); msi = false; } if (!msi) { hidma_ll_setup_irq(dmadev->lldev, false); rc = devm_request_irq(&pdev->dev, chirq, hidma_chirq_handler, 0, "qcom-hidma", dmadev->lldev); if (rc) goto uninit; } > hidma_free_msis(dmadev); > > - hidma_debug_uninit(dmadev); > hidma_ll_uninit(dmadev->lldev); > dmafree: > if (dmadev) ^^^^^^ This test isn't necessary and should be deleted. regards, dan carpenter
Powered by blists - more mailing lists