linux-kernel - Re: [PATCH 1/5] dt-bindings: bus: Add firewall bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13b16e13-690b-ad3f-a800-28c7805cbb96@st.com>
Date:   Tue, 28 Apr 2020 13:13:45 +0000
From:   Benjamin GAIGNARD <benjamin.gaignard@...com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        "Greg KH" <gregkh@...uxfoundation.org>,
        Loic PALLARDY <loic.pallardy@...com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/5] dt-bindings: bus: Add firewall bindings



On 4/28/20 1:24 PM, Linus Walleij wrote:
> Hi Benjamin,
>
> On Mon, Apr 20, 2020 at 3:48 PM Benjamin Gaignard
> <benjamin.gaignard@...com> wrote:
>> Add schemas for firewall consumer and provider.
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>
>> +$id: http://devicetree.org/schemas/bus/stm32/firewall-consumer.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Common Bus Firewall consumer binding
>> +
>> +maintainers:
>> +  - Benjamin Gaignard <benjamin.gaignard@...com>
> This really needs a description: to tell what is going on and what
> these firewalls
> are for and how they are supposed to work.
Hi Linus,

Does the following description sound good for you:
Firewall properties provide the possible firewall bus controller 
configurations for a device.
Bus firewall controllers are typically used to control if a hardware 
block can perform read or write operations on bus.
The contents of the firewall bus configuration properties are defined by 
the binding for the individual firewall controller device.
The first configuration 'firewall-0' or the one named 'default' is 
applied before probing the device itself.

Regards,
Benjamin
>
> I suppose just a bit of cut'n'paste from the cover letter :D
>
> Otherwise it looks good to me.
>
> Yours,
> Linus Walleij