linux-kernel - Re: [PATCH] gpio: of: Build fails if CONFIG_OF_DYNAMIC enabled without CONFIG_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdY=CvSyKO+LpGqu06XVq5pdwycMwyey3U=-qzFY+Dpv4g@mail.gmail.com>
Date:   Tue, 28 Apr 2020 16:00:36 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     David Gow <davidgow@...gle.com>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Frank Rowand <frank.rowand@...y.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: of: Build fails if CONFIG_OF_DYNAMIC enabled
 without CONFIG_OF_GPIO

On Sat, Apr 25, 2020 at 6:46 AM David Gow <davidgow@...gle.com> wrote:

> The symbol 'gpio_of_notifier' doesn't exist without both CONFIG_OF_GPIO
> and CONFIG_OF_DYNAMIC enabled, but is referenced when only
> CONFIG_OF_DYNAMIC is enabled.
>
> This broke building with 'make ARCH=um allyesconfig':
> ---------------
> /usr/bin/ld: drivers/gpio/gpiolib.o: in function `gpiolib_dev_init':
> ./drivers/gpio/gpiolib.c:5293: undefined reference to `gpio_of_notifier'
> collect2: error: ld returned 1 exit status
> ---------------
>
> Fixes: 63636d956c45 ("gpio: of: Add DT overlay support for GPIO hogs")
> Signed-off-by: David Gow <davidgow@...gle.com>

Patch applied for fixes since it fixes a regression,
I recommend looking a bit down the dependency
chain as indicated by Geert if you have time!

Yours,
Linus Walleij