linux-kernel - Re: [RFC PATCH v1 3/5] media: tegra-video: Move PM runtime handle to streaming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d069601-5507-dc8f-0cbc-acd8fd7324b3@gmail.com>
Date:   Tue, 28 Apr 2020 17:05:34 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Sowjanya Komatineni <skomatineni@...dia.com>,
        thierry.reding@...il.com, jonathanh@...dia.com, frankc@...dia.com,
        hverkuil@...all.nl
Cc:     linux-media@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v1 3/5] media: tegra-video: Move PM runtime handle to
 streaming

28.04.2020 07:20, Sowjanya Komatineni пишет:
> +	ret = csi->ops->csi_streaming(csi_chan, chan->pg_mode, enable);
>  
> -	return csi->ops->csi_streaming(csi_chan, chan->pg_mode, enable);
> +	if ((ret < 0 || !enable) && atomic_dec_and_test(&csi->clk_refcnt))
> +		pm_runtime_put_sync(csi->dev);

There shouldn't be a need to sync the RPM here, hence just
pm_runtime_put(csi->dev). Same for the VI.