linux-kernel - Re: [PATCH v2] arm64: kexec_file: Avoid temp buffer for RNG seed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <158807855142.208424.6865350866606582490.b4-ty@kernel.org>
Date:   Tue, 28 Apr 2020 15:49:39 +0100
From:   Will Deacon <will@...nel.org>
To:     George Spelvin <lkml@....ORG>
Cc:     catalin.marinas@....com, Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        lkml@....org, Hsin-Yi Wang <hsinyi@...omium.org>
Subject: Re: [PATCH v2] arm64: kexec_file: Avoid temp buffer for RNG seed

On Mon, 30 Mar 2020 17:38:01 +0000, George Spelvin wrote:
> After using get_random_bytes(), you want to wipe the buffer
> afterward so the seed remains secret.
> 
> In this case, we can eliminate the temporary buffer entirely.
> fdt_setprop_placeholder() returns a pointer to the property value
> buffer, allowing us to put the random data directly in there without
> using a temporary buffer at all.  Faster and less stack all in one.

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: kexec_file: Avoid temp buffer for RNG seed
      https://git.kernel.org/arm64/c/99ee28d99607

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev