lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Apr 2020 00:05:34 +0800 From: Chun-Kuang Hu <chunkuang.hu@...nel.org> To: Chun-Kuang Hu <chunkuang.hu@...nel.org>, YueHaibing <yuehaibing@...wei.com>, Philipp Zabel <p.zabel@...gutronix.de>, David Airlie <airlied@...ux.ie>, Matthias Brugger <matthias.bgg@...il.com>, CK Hu <ck.hu@...iatek.com>, Enric Balletbo i Serra <enric.balletbo@...labora.com>, DRI Development <dri-devel@...ts.freedesktop.org>, linux-kernel <linux-kernel@...r.kernel.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org> Cc: Daniel Vetter <daniel@...ll.ch> Subject: Re: [PATCH -next] drm/mediatek: Fix Kconfig warning Daniel Vetter <daniel@...ll.ch> 於 2020年4月28日 週二 下午10:55寫道: > > On Sun, Apr 26, 2020 at 04:20:39PM +0800, Chun-Kuang Hu wrote: > > Hi, YueHaibing: > > > > YueHaibing <yuehaibing@...wei.com> 於 2020年4月20日 週一 下午10:04寫道: > > > > > > WARNING: unmet direct dependencies detected for MTK_MMSYS > > > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n] > > > Selected by [y]: > > > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] > > > > > > Add missing dependcy COMMON_CLK_MT8173_MMSYS to fix this. > > > > From the code relationship, mediatek drm has relation with mediatek > > mmsys, and mediatek mmsys has relation with medaitek clock. > > So I think it's better that CONFIG_MTK_MMSYS select > > CONFIG_COMMON_CLK_MT8173_MMSYS. > > select is very strongly discouraged and should only be used for Kconfig > symbols not visible to users. Okay, maybe the better solution is that DRM_MEDIATEK depend on MTK_MMSYS. Regards, Chun-Kuang. > -Daniel > > > > > Regards, > > Chun-Kuang. > > > > > > > > Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device") > > > Signed-off-by: YueHaibing <yuehaibing@...wei.com> > > > --- > > > drivers/gpu/drm/mediatek/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > > > index c420f5a3d33b..4d9b5540de68 100644 > > > --- a/drivers/gpu/drm/mediatek/Kconfig > > > +++ b/drivers/gpu/drm/mediatek/Kconfig > > > @@ -6,6 +6,7 @@ config DRM_MEDIATEK > > > depends on COMMON_CLK > > > depends on HAVE_ARM_SMCCC > > > depends on OF > > > + depends on COMMON_CLK_MT8173_MMSYS > > > select DRM_GEM_CMA_HELPER > > > select DRM_KMS_HELPER > > > select DRM_MIPI_DSI > > > -- > > > 2.17.1 > > > > > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
Powered by blists - more mailing lists