linux-kernel - Re: [PATCH v3 05/10] x86/fpu/xstate: Define new functions for clearing fpregs and xstates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Apr 2020 19:32:24 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Yu-cheng Yu <yu-cheng.yu@...el.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>,
        Andy Lutomirski <luto@...nel.org>,
        Rik van Riel <riel@...riel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@...el.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v3 05/10] x86/fpu/xstate: Define new functions for
 clearing fpregs and xstates

On Wed, Apr 29, 2020 at 10:02:46AM -0700, Yu-cheng Yu wrote:
> It has been some time since Thomas commented on this tail comment.
> https://lore.kernel.org/lkml/alpine.DEB.2.21.1908161703010.1923@nanos.tec.linutronix.de/
> 
> I think why not fixing it while at it.

So "fixing it" means removing it or putting it *over* the line?

If you think the comment is obvious and superfluous, then say so in the
commit message "remove obvious side-comment in fpu__clear(), while at
it." to let readers know *why* you've done it, especially since it is a
side-change, not really related to what the patch is trying to do.

Otherwise, readers like me wonder: why is he doing that? What else is
he doing in that patch that doesn't belong here? Why isn't that patch
straightforward doing one thing and one thing only and doing other
stuff?

This certainly doesn't make review easier.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette