linux-kernel - Re: [PATCH v2 1/2] coresight: Include required headers in C files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANLsYkzkq=EuKx_=W2jv2TeWpM3P=Pd9NYS18VfG9KCey=2--g@mail.gmail.com>
Date:   Wed, 29 Apr 2020 13:24:42 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Douglas Anderson <dianders@...omium.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Mike Leach <mike.leach@...aro.org>
Subject: Re: [PATCH v2 1/2] coresight: Include required headers in C files

On Wed, 29 Apr 2020 at 12:31, Stephen Boyd <swboyd@...omium.org> wrote:
>
> Quoting Mathieu Poirier (2020-04-29 11:08:18)
> > Hi Stephen,
> >
> > On Tue, Apr 28, 2020 at 11:10:09AM -0700, Stephen Boyd wrote:
> > > diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c
> > > index aeea39cbd161..77e14e770806 100644
> > > --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c
> > > +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c
> > > @@ -4,7 +4,14 @@
> > >   * Author: Mike Leach <mike.leach@...aro.org>
> > >   */
> > >
> > > +#include <linux/atomic.h>
> > >  #include <linux/coresight.h>
> > > +#include <linux/device.h>
> > > +#include <linux/io.h>
> > > +#include <linux/kernel.h>
> > > +#include <linux/slab.h>
> > > +#include <linux/spinlock.h>
> > > +#include <linux/sysfs.h>
> >
> > What is io.h and slab.h used for in coresight-cti-sysfs.c ?
>
> io.h is for readl_relaxed() usage in this file. I added slab for the
> devm_kcalloc() but it doesn't look necessary given that device.h is
> where that is defined, not slab.h. Thanks for catching that!
>
> >
> > >
> > >  #include "coresight-cti.h"
> > >
> > > diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c
> > > index 7fc1fc8d7738..be61c1705916 100644
> > > --- a/drivers/hwtracing/coresight/coresight-cti.c
> > > +++ b/drivers/hwtracing/coresight/coresight-cti.c
> > > @@ -4,7 +4,20 @@
> > >   * Author: Mike Leach <mike.leach@...aro.org>
> > >   */
> > >
> > > +#include <linux/amba/bus.h>
> > > +#include <linux/atomic.h>
> > > +#include <linux/bits.h>
> > > +#include <linux/coresight.h>
> > > +#include <linux/device.h>
> > > +#include <linux/io.h>
> >
> > Same comment as above.
> >
> > No need to send another version if these are mistakes - just let me know and
> > I'll do the adjustment.
> >
>
> Same here, io.h is for the readl_relaxed() and writel_relaxed() calls.

I just noticed the "asm/io.h" at the top of linux/io.h - ok for that one.

>
> So please remove slab.h from the two files (but not the other one) when
> applying. Thanks.

You got it.