linux-kernel - Re: [PATCH] HID: mcp2221: add gpiolib dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2004292147030.19713@cbobk.fhfr.pm>
Date:   Wed, 29 Apr 2020 21:47:12 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Rishi Gupta <gupt21@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bastien Nocera <bnocera@...hat.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Wolfram Sang <wsa@...-dreams.de>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: mcp2221: add gpiolib dependency

On Tue, 28 Apr 2020, Arnd Bergmann wrote:

> Without gpiolib, this driver fails to link:
> 
> arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `mcp2221_probe':
> hid-mcp2221.c:(.text+0x1b0): undefined reference to `devm_gpiochip_add_data'
> arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `mcp_gpio_get':
> hid-mcp2221.c:(.text+0x30c): undefined reference to `gpiochip_get_data'
> 
> Fixes: 328de1c519c5 ("HID: mcp2221: add GPIO functionality support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.

-- 
Jiri Kosina
SUSE Labs