linux-kernel - Re: [PATCH] misc: fastrpc: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1471e6f6-fd20-334a-041b-9d55be234111@web.de>
Date:   Wed, 29 Apr 2020 22:40:14 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-arm-msm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] misc: fastrpc: fix memory leak

> if misc_register() fails, previously allocated data is left without freeing,
> this could result in memory leak.

How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] misc: fastrpc: Fix an incomplete memory release in fastrpc_rpmsg_probe()

   Change description:
   A few fastrpc data were not released after a call of the
   function “misc_register” failed.
   Thus add a call of the function “kfree”.

> So fix it!

Would you like to replace such an information by the tag “Fixes”?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=96c9a7802af7d500a582d89a8b864584fe878c1b#n183

Regards,
Markus