[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200429213034.GA29572@bogus>
Date: Wed, 29 Apr 2020 16:30:34 -0500
From: Rob Herring <robh@...nel.org>
To: Macpaul Lin <macpaul.lin@...iatek.com>
Cc: Min Guo <min.Guo@...iatek.com>,
Chunfeng Yun <chunfeng.yun@...iatek.com>,
Kishon Vijay Abraham I <kishon@...com>,
Matthias Brugger <matthias.bgg@...il.com>,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org,
Mediatek WSD Upstream <wsd_upstream@...iatek.com>,
Macpaul Lin <macpaul.lin@...il.com>
Subject: Re: [PATCH 1/2] dt-bindings: phy-mtk-tphy: add the property about
force_vbus
On Fri, Apr 17, 2020 at 01:23:05PM +0800, Macpaul Lin wrote:
> For some platforms, they don't have vbus pin connection between usb's phy
> and mac. Hence we need to control force_vbus related registers to keep
> hardware works normal.
> This patch add the required bool property force_vbus.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> ---
> Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt
> index dd75b676b71d..6b49b651becc 100644
> --- a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt
> @@ -37,6 +37,9 @@ Optional properties (controller (parent) node):
> calibrate
> - mediatek,src-coef : coefficient for slew rate calibrate, depends on
> SoC process
> + - force_vbus : if the platform has no vbus connection between phy and mac,
mediatek,force-vbus
This is board specific? If SoC specific, you should drop and imply this
from the compatible string.
> + (force_vbus mode), then this property should be exist.
> + Otherwise not to add this property.
>
> Required properties (port (child) node):
> - reg : address and length of the register set for the port.
> --
> 2.18.0
Powered by blists - more mailing lists