linux-kernel - Re: [PATCH net-next v2 6/7] net: bcmgenet: add support for ethtool rxnfc flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86fece02-5fc3-43c5-174c-7b732c4e09fd@gmail.com>
Date:   Wed, 29 Apr 2020 14:47:54 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Doug Berger <opendmb@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 6/7] net: bcmgenet: add support for ethtool
 rxnfc flows

On 4/29/20 1:02 PM, Doug Berger wrote:
> This commit enables driver support for ethtool commands of this form:
> ethtool -N|-U|--config-nfc|--config-ntuple devname
>     flow-type ether|ip4
>     [src xx:yy:zz:aa:bb:cc [m xx:yy:zz:aa:bb:cc]]
>     [dst xx:yy:zz:aa:bb:cc [m xx:yy:zz:aa:bb:cc]] [proto N [m N]]
>     [src-ip x.x.x.x [m x.x.x.x]] [dst-ip x.x.x.x [m x.x.x.x]] [tos N [m N]]
>     [l4proto N [m N]] [src-port N [m N]] [dst-port N [m N]] [spi N [m N]]
>     [l4data N [m N]] [vlan-etype N [m N]] [vlan N [m N]]
>     [dst-mac xx:yy:zz:aa:bb:cc [m xx:yy:zz:aa:bb:cc]] [action 0] [loc N] |
>     delete N
> 
> Since there is only one Rx Ring in this implementation action 0 behaves no
> differently from not specifying a rule.
> 
> The rules can be seen with ethtool commands of this form:
> ethtool -n|-u|--show-nfc|--show-ntuple devname [rule N]
> 
> Signed-off-by: Doug Berger <opendmb@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

I thought the Roboswitch CFP was hard, but this is another whole level
of insane :)
-- 
Florian