[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200429223105.2echdvu745d6xbx2@earth.universe>
Date: Thu, 30 Apr 2020 00:31:05 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Dan Murphy <dmurphy@...com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: Add the BQ27561 fuel gauge
bindings
Hi,
On Fri, Apr 17, 2020 at 12:22:26PM -0500, Dan Murphy wrote:
> Introduce the Texas Instrument BQ27561 and BQ27750 fuel gauge device
> tree bindings.
>
> Cc: Rob Herring <robh@...nel.org>
> Signed-off-by: Dan Murphy <dmurphy@...com>
> ---
I think its best to just add them to bq27xxx.txt. Conversion to YAML
would still be nice of course :)
In any case the binding is incomplete, since batteries should contain
a power-supplies node referencing their charger via a phandle, see
power_suppliy.txt (which still needs to be converted to YAML).
-- Sebastian
> .../bindings/power/supply/bq27561.yaml | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/bq27561.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq27561.yaml b/Documentation/devicetree/bindings/power/supply/bq27561.yaml
> new file mode 100644
> index 000000000000..abc9acdbc704
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/bq27561.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (C) 2020 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/bq27561.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: TI BQ27561 and BQ27750 Fuel Gauges
> +
> +maintainers:
> + - Dan Murphy <dmurphy@...com>
> +
> +description: |
> + The bq27z561 device provides a feature-rich gas gauging solution for
> + single-cell battery pack applications.
> +
> + Specifications about the charger can be found at:
> + https://www.ti.com/lit/gpn/bq27z561
> + https://www.ti.com/lit/gpn/bq27750
> +
> +properties:
> + compatible:
> + enum:
> + - ti,bq27561
> + - ti,bq27750
> +
> + reg:
> + maxItems: 1
> + description: |
> + I2C address of the device which is 0x55
> +
> +required:
> + - compatible
> + - reg
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + fuel_gauge@55 {
> + compatible = "ti,bq27561";
> + reg = <0x55>;
> + };
> + };
> --
> 2.25.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists