| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202004291457.0gvGWfAD%lkp@intel.com>
Date: Wed, 29 Apr 2020 14:15:52 +0800
From: kbuild test robot <lkp@...el.com>
To: Rishabh Bhatnagar <rishabhb@...eaurora.org>,
linux-remoteproc@...r.kernel.org, bjorn.andersson@...aro.org
Cc: kbuild-all@...ts.01.org, ohad@...ery.com,
linux-kernel@...r.kernel.org, tsoni@...eaurora.org,
psodagud@...eaurora.org, sidgup@...eaurora.org,
Rishabh Bhatnagar <rishabhb@...eaurora.org>
Subject: Re: [PATCH v3 1/2] remoteproc: qcom: Add per subsystem SSR
notification
Hi Rishabh,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.7-rc3 next-20200428]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Rishabh-Bhatnagar/Extend-SSR-notifications-framework/20200429-071958
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 96c9a7802af7d500a582d89a8b864584fe878c1b
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
drivers/soc/qcom/glink_ssr.c: In function 'qcom_glink_ssr_probe':
>> drivers/soc/qcom/glink_ssr.c:128:36: error: passing argument 1 of 'qcom_register_ssr_notifier' from incompatible pointer type [-Werror=incompatible-pointer-types]
128 | return qcom_register_ssr_notifier(&ssr->nb);
| ^~~~~~~~
| |
| struct notifier_block *
In file included from drivers/soc/qcom/glink_ssr.c:11:
include/linux/remoteproc/qcom_rproc.h:13:7: note: expected 'const char *' but argument is of type 'struct notifier_block *'
13 | void *qcom_register_ssr_notifier(const char *name, struct notifier_block *nb);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/qcom/glink_ssr.c:128:9: error: too few arguments to function 'qcom_register_ssr_notifier'
128 | return qcom_register_ssr_notifier(&ssr->nb);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/soc/qcom/glink_ssr.c:11:
include/linux/remoteproc/qcom_rproc.h:13:7: note: declared here
13 | void *qcom_register_ssr_notifier(const char *name, struct notifier_block *nb);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/glink_ssr.c: In function 'qcom_glink_ssr_remove':
>> drivers/soc/qcom/glink_ssr.c:135:2: error: too few arguments to function 'qcom_unregister_ssr_notifier'
135 | qcom_unregister_ssr_notifier(&ssr->nb);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/soc/qcom/glink_ssr.c:11:
include/linux/remoteproc/qcom_rproc.h:14:5: note: declared here
14 | int qcom_unregister_ssr_notifier(void *notify, struct notifier_block *nb);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/soc/qcom/glink_ssr.c: In function 'qcom_glink_ssr_probe':
>> drivers/soc/qcom/glink_ssr.c:129:1: warning: control reaches end of non-void function [-Wreturn-type]
129 | }
| ^
cc1: some warnings being treated as errors
vim +/qcom_register_ssr_notifier +128 drivers/soc/qcom/glink_ssr.c
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 111
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 112 static int qcom_glink_ssr_probe(struct rpmsg_device *rpdev)
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 113 {
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 114 struct glink_ssr *ssr;
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 115
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 116 ssr = devm_kzalloc(&rpdev->dev, sizeof(*ssr), GFP_KERNEL);
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 117 if (!ssr)
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 118 return -ENOMEM;
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 119
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 120 init_completion(&ssr->completion);
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 121
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 122 ssr->dev = &rpdev->dev;
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 123 ssr->ept = rpdev->ept;
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 124 ssr->nb.notifier_call = qcom_glink_ssr_notify;
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 125
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 126 dev_set_drvdata(&rpdev->dev, ssr);
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 127
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 @128 return qcom_register_ssr_notifier(&ssr->nb);
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 @129 }
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 130
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 131 static void qcom_glink_ssr_remove(struct rpmsg_device *rpdev)
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 132 {
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 133 struct glink_ssr *ssr = dev_get_drvdata(&rpdev->dev);
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 134
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 @135 qcom_unregister_ssr_notifier(&ssr->nb);
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 136 }
c4d77d5fcd8bae Bjorn Andersson 2017-07-24 137
:::::: The code at line 128 was first introduced by commit
:::::: c4d77d5fcd8baefb358ae921b940e9bbd09a751e soc: qcom: GLINK SSR notifier
:::::: TO: Bjorn Andersson <bjorn.andersson@...aro.org>
:::::: CC: Bjorn Andersson <bjorn.andersson@...aro.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (48802 bytes)
Powered by blists - more mailing lists