linux-kernel - Re: [PATCH 1/4 v2] firmware: stratix10-svc: Fix genpool creation error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <eb56faac-657a-e977-3be1-5f0a78ca509c@web.de>
Date:   Wed, 29 Apr 2020 11:50:25 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Christophe Jaillet <christophe.jaillet@...adoo.fr>,
        Richard Gong <richard.gong@...ux.intel.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alan Tull <atull@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Moritz Fischer <mdf@...nel.org>
Subject: Re: [PATCH 1/4 v2] firmware: stratix10-svc: Fix genpool creation
 error handling

> 'svc_create_memory_pool()' returns an error pointer on error, not NULL.

Such information is helpful.


> Fix the corresponding test and return value accordingly.
>
> Move the genpool allocation after a few devm_kzalloc in order to ease
> error handling.

How do you think about a wording variant like the following?

   Change description:
   * Use a check of the failure predicate which is documented for
     the svc_create_memory_pool() function in the same source file.

   * Move the genpool allocation behind a few devm_kzalloc() calls
     in order to ease exception handling.

Regards,
Markus