linux-kernel - RE: [PATCH] ARC: guard dsp early init against non ARCv2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH2PR12MB3782E5561AB98EDA1E350C02CBAD0@CH2PR12MB3782.namprd12.prod.outlook.com>
Date:   Wed, 29 Apr 2020 10:03:21 +0000
From:   Angelo Ribeiro <Angelo.Ribeiro@...opsys.com>
To:     Jose Abreu <Jose.Abreu@...opsys.com>,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        Vineet Gupta <Vineet.Gupta1@...opsys.com>
CC:     Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ARC: guard dsp early init against non ARCv2

Hi Eugeniy,

Tested okay on a ARCv1.

Thanks
Angelo

Tested-by: Angelo Ribeiro <angelo.ribeiro@...opsys.com>

From: Jose Abreu <joabreu@...opsys.com>
Date: Wed, Apr 29, 2020 at 07:19:55

> From: Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
> Date: Apr/28/2020, 19:50:24 (UTC+00:00)
> 
> > As of today we guard early DSP init code with
> > ARC_AUX_DSP_BUILD (0x7A) BCR check to verify that we have
> > CPU with DSP configured. However that's not enough as in
> > ARCv1 CPU the same BCR (0x7A) is used for checking MUL/MAC
> > instructions presence.
> > 
> > So, let's guard DSP early init against non ARCv2.
> > 
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
> 
> Reported-by: Angelo Ribeiro 
> <angelor@...opsys.com>
> 
> ---
> Thanks,
> Jose Miguel Abreu