[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a43d4e21-d4e7-a439-946d-306db7f7a5d6@huawei.com>
Date: Wed, 29 Apr 2020 09:50:25 +0800
From: tanhuazhong <tanhuazhong@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <salil.mehta@...wei.com>,
<yisen.zhuang@...wei.com>, <linuxarm@...wei.com>,
Yonglong Liu <liuyonglong@...wei.com>
Subject: Re: [PATCH net-next] net: hns3: adds support for reading module
eeprom info
On 2020/4/29 2:49, Jakub Kicinski wrote:
> On Tue, 28 Apr 2020 19:58:25 +0800 Huazhong Tan wrote:
>> From: Yonglong Liu <liuyonglong@...wei.com>
>>
>> This patch adds support for reading the optical module eeprom
>> info via "ethtool -m".
>>
>> Signed-off-by: Yonglong Liu <liuyonglong@...wei.com>
>> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
>
>> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
>> index 4d9c85f..8364e1b 100644
>> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
>> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
>> @@ -12,6 +12,16 @@ struct hns3_stats {
>> int stats_offset;
>> };
>>
>> +#define HNS3_MODULE_TYPE_QSFP 0x0C
>> +#define HNS3_MODULE_TYPE_QSFP_P 0x0D
>> +#define HNS3_MODULE_TYPE_QSFP_28 0x11
>> +#define HNS3_MODULE_TYPE_SFP 0x03
>
> Could you use the SFF8024_ID_* defines from sfp.h here as well?
>
Yes, will send V2 to do that.
> Otherwise looks good to me!
>
Thanks:)
> .
>
Powered by blists - more mailing lists