linux-kernel - Re: [RFC PATCH 3/3] sched,rt: break out of load balancing if an RT task appears

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jhjr1w6pkkc.mognet@arm.com>
Date:   Wed, 29 Apr 2020 13:01:39 +0100
From:   Valentin Schneider <valentin.schneider@....com>
To:     Scott Wood <swood@...hat.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Rik van Riel <riel@...riel.com>,
        Mel Gorman <mgorman@...e.de>, linux-kernel@...r.kernel.org,
        linux-rt-users <linux-rt-users@...r.kernel.org>
Subject: Re: [RFC PATCH 3/3] sched,rt: break out of load balancing if an RT task appears


On 28/04/20 23:33, Scott Wood wrote:
>> > +
>> > +/* Is there a task of a high priority class? */
>> > +static inline bool rq_has_runnable_rt_task(struct rq *rq)
>> > +{
>> > +	return unlikely(rq->nr_running != rq->cfs.h_nr_running);
>>
>> Seeing as that can be RT, DL or stopper, that name is somewhat misleading.
>
> rq_has_runnable_rt_dl_task()?  Or is there some term that unambiguously
> encompasses both?
>

Naming is a pain as always; I'd shove it in fair.c as
"rq_has_higher_tasks()" or similar.

> -Scott