linux-kernel - Re: [PATCH] gpiolib: don't call sleeping functions with a spinlock taken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeGQzXfzzRR2EM5zwb8EfiyxAOJFqQuAFH-C2zdNAGjYw@mail.gmail.com>
Date:   Wed, 29 Apr 2020 15:37:50 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: don't call sleeping functions with a spinlock taken

On Wed, Apr 29, 2020 at 9:40 AM Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:
> wt., 28 kwi 2020 o 17:53 Andy Shevchenko <andy.shevchenko@...il.com> napisał(a):
> > On Tue, Apr 14, 2020 at 6:35 PM Bartosz Golaszewski
> > <bgolaszewski@...libre.com> wrote:
> > > wt., 14 kwi 2020 o 14:00 Linus Walleij <linus.walleij@...aro.org> napisał(a):
> > > > On Fri, Mar 20, 2020 at 10:31 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:

...

> > It looks like we need a mutex less function which can be used here and
> > in the call you are considering racy.
>
> The thing is this mutex is in pinctrl - we'd need to export it too so
> that gpio can use it.

Oh, I see now. So, something like

pinctrl_ext_operation_begin()
....
pinctrl_ext_operation_end()

perhaps.

-- 
With Best Regards,
Andy Shevchenko