linux-kernel - Re: [PATCH] clk/meson: Complete exception handling in meson8b_clkc_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ceba9706-0819-54cf-c3d3-9ceb93d31c5e@web.de>
Date:   Wed, 29 Apr 2020 15:30:20 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Bernard Zhao <bernard@...o.com>, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        opensource.kernel@...o.com, Jerome Brunet <jbrunet@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH] clk/meson: Complete exception handling in
 meson8b_clkc_init_common()

> In common init function, when run into err branch, we didn`t
> use kfree to release kzmalloc area, this may bring in memleak

* I suggest to improve also this change description.

* Please move the resource release functions to end of
  the function “meson8b_clkc_init_common” here.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=96c9a7802af7d500a582d89a8b864584fe878c1b#n450

* Will the tag “Fixes” be relevant then for the completed exception handling?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=96c9a7802af7d500a582d89a8b864584fe878c1b#n183

Regards,
Markus