linux-kernel - Re: [PATCH v3 1/5] w1_therm: fix reset_select_slave. Creating w1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200429134357.GA2132814@kroah.com>
Date:   Wed, 29 Apr 2020 15:43:57 +0200
From:   Greg KH <greg@...ah.com>
To:     Akira Shimahara <akira215corp@...il.com>
Cc:     zbr@...emap.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/5] w1_therm: fix reset_select_slave. Creating
 w1_therm.h

On Wed, Apr 29, 2020 at 03:30:48PM +0200, Akira Shimahara wrote:
> Patch for enhancement of w1_therm module.
>  - Creating a w1_therm.h file to clean up the code and documenting it.
>  - fix reset_select_slave function: w1_reset_select_slave() from w1_io.c
> 	could not be used here because a SKIP ROM command is sent if only
> 	one device is on the line. At the beginning of the search process,
> 	sl->master->slave_count is 1 even if more devices are on the line,
> 	causing data collision in the bus.

This should be three different patches, one to create the file by moving
the code, one to document it, and the last to do the fix.

thanks,

greg k-h