lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Apr 2020 16:02:17 +0200 From: Enric Balletbo i Serra <enric.balletbo@...labora.com> To: YueHaibing <yuehaibing@...wei.com>, chunkuang.hu@...nel.org, p.zabel@...gutronix.de, airlied@...ux.ie, daniel@...ll.ch, matthias.bgg@...il.com, ck.hu@...iatek.com Cc: linux-kernel@...r.kernel.orc, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning Hi YueHaibing, Thank you for your patch. On 29/4/20 9:13, YueHaibing wrote: > WARNING: unmet direct dependencies detected for MTK_MMSYS > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n] > Selected by [y]: > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] > > Make DRM_MEDIATEK depend on MTK_MMSYS to fix this. > > Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device") > Signed-off-by: YueHaibing <yuehaibing@...wei.com> Definitively we shouldn't select the MTK_MMSYS and we should depend on MTK_MMSYS instead, so Reviewed-by: Enric Balletbo i Serra <enric.balletbo@...labora.com> > --- > v3: make DRM_MEDIATEK depends on MTK_MMSYS > v2: select COMMON_CLK_MT8173_MMSYS instead of adding DRM_MEDIATEK dependency > --- > drivers/gpu/drm/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index c420f5a3d33b..aa74aac3cbcc 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -6,12 +6,12 @@ config DRM_MEDIATEK > depends on COMMON_CLK > depends on HAVE_ARM_SMCCC > depends on OF > + depends on MTK_MMSYS > select DRM_GEM_CMA_HELPER > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select DRM_PANEL > select MEMORY > - select MTK_MMSYS > select MTK_SMI > select VIDEOMODE_HELPERS > help >
Powered by blists - more mailing lists