linux-kernel - Re: [PATCH] drm/ast: remove duplicate assignment of ast_crtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43183725-a490-611d-bf4d-fc23cfca44d9@suse.de>
Date:   Wed, 29 Apr 2020 16:57:44 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Jason Yan <yanaijie@...wei.com>, airlied@...hat.com,
        airlied@...ux.ie, daniel@...ll.ch, kraxel@...hat.com,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/ast: remove duplicate assignment of ast_crtc_funcs
 member

Hi

Am 29.04.20 um 16:10 schrieb Jason Yan:
> The struct member 'set_config' was assigned twice:
> 
> static const struct drm_crtc_funcs ast_crtc_funcs = {
> 	.reset = ast_crtc_reset,
> 	.set_config = drm_crtc_helper_set_config,
> 	......
> 	.set_config = drm_atomic_helper_set_config,
> 	......
> };
> 
> Since the second one is which we use now in fact, we can remove the
> first one.
> 
> This fixes the following coccicheck warning:
> 
> drivers/gpu/drm/ast/ast_mode.c:932:50-51: set_config: first occurrence
> line 934, second occurrence line 937
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

Thanks! I'll apply the patch to drm-misc-next soonish.

Best regards
Thomas

> ---
>  drivers/gpu/drm/ast/ast_mode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index d2ab81f9c498..7062bcd78740 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -931,7 +931,6 @@ static void ast_crtc_atomic_destroy_state(struct drm_crtc *crtc,
>  
>  static const struct drm_crtc_funcs ast_crtc_funcs = {
>  	.reset = ast_crtc_reset,
> -	.set_config = drm_crtc_helper_set_config,
>  	.gamma_set = drm_atomic_helper_legacy_gamma_set,
>  	.destroy = ast_crtc_destroy,
>  	.set_config = drm_atomic_helper_set_config,
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)