linux-kernel - Re: [v3] checkpatch: add dedicated checker for 'Fixes:' tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1234e16-eca2-e2af-c5a6-92f47fcbd98d@web.de>
Date:   Wed, 29 Apr 2020 17:18:52 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wang YanQing <udknight@...il.com>, kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Andy Whitcroft <apw@...onical.com>,
        Joe Perches <joe@...ches.com>, Matteo Croce <mcroce@...hat.com>
Subject: Re: [v3] checkpatch: add dedicated checker for 'Fixes:' tag

>> * Do you try to extend the existing software analysis approach “GIT_COMMIT_ID”?
>>
>> * Would you like to avoid the development of duplicate Perl code?
>
> Fixes: lines don't need to have a "commit" prefix before the commit id, the description
> in normal commit id could across multiple lines, and we don't need to consider the
> $commit_log_possible_stack_dump for 'Fixes:' tag line.

It can be helpful to know such differences.

> I mean it will make the GIT_COMMIT_ID code become harder to read and maintain.

This view depends on some factors.

* How many data processing can be shared for your software extension?

* Do you get any further development ideas from a previous suggestion
  by Joe Perches according to the discussion topic “linux-next:
  Fixes tag needs some work in the tip tree”?
  https://lkml.org/lkml/2019/1/17/966
  https://lore.kernel.org/lkml/40bfc40958fca6e2cc9b86101153aa0715fac4f7.camel@perches.com/

Regards,
Markus