lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Apr 2020 15:33:32 +0000 From: "Saleem, Shiraz" <shiraz.saleem@...el.com> To: "Denis V. Lunev" <den@...nvz.org> CC: Konstantin Khorenko <khorenko@...tuozzo.com>, "Latif, Faisal" <faisal.latif@...el.com>, Doug Ledford <dledford@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH 1/1] i40iw: remove bogus call to netdev_master_upper_dev_get > Subject: [PATCH 1/1] i40iw: remove bogus call to netdev_master_upper_dev_get > > Local variable netdev is not used in these calls. > > It should be noted, that this change is required to work in bonded mode. > In the other case we would get the following assert: > "RTNL: assertion failed at net/core/dev.c (5665)" > with the calltrace as follows: > dump_stack+0x19/0x1b > netdev_master_upper_dev_get+0x61/0x70 > i40iw_addr_resolve_neigh+0x1e8/0x220 > i40iw_make_cm_node+0x296/0x700 > ? i40iw_find_listener.isra.10+0xcc/0x110 > i40iw_receive_ilq+0x3d4/0x810 > i40iw_puda_poll_completion+0x341/0x420 > i40iw_process_ceq+0xa5/0x280 > i40iw_ceq_dpc+0x1e/0x40 > tasklet_action+0x83/0x140 > __do_softirq+0x125/0x2bb > call_softirq+0x1c/0x30 > do_softirq+0x65/0xa0 > irq_exit+0x105/0x110 > do_IRQ+0x56/0xf0 > common_interrupt+0x16a/0x16a > ? cpuidle_enter_state+0x57/0xd0 > cpuidle_idle_call+0xde/0x230 > arch_cpu_idle+0xe/0xc0 > cpu_startup_entry+0x14a/0x1e0 > start_secondary+0x1f7/0x270 > start_cpu+0x5/0x14 > > Signed-off-by: Denis V. Lunev <den@...nvz.org> > CC: Konstantin Khorenko <khorenko@...tuozzo.com> > CC: Faisal Latif <faisal.latif@...el.com> > CC: Shiraz Saleem <shiraz.saleem@...el.com> > CC: Doug Ledford <dledford@...hat.com> > CC: Jason Gunthorpe <jgg@...pe.ca> > CC: linux-rdma@...r.kernel.org > CC: linux-kernel@...r.kernel.org > --- > drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 -------- > 1 file changed, 8 deletions(-) > Looks right. Thanks! Acked-by: Shiraz Saleem <shiraz.saleem@...el.com>
Powered by blists - more mailing lists