linux-kernel - Re: [PATCH v2 2/2] dt-bindings: serial: Convert 8250 to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200430141949.GA21645@bogus>
Date:   Thu, 30 Apr 2020 09:19:49 -0500
From:   Rob Herring <robh@...nel.org>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Lubomir Rintel <lkundrak@...sk>
Subject: Re: [PATCH v2 2/2] dt-bindings: serial: Convert 8250 to json-schema

On Sun, 19 Apr 2020 22:17:16 +0200, Lubomir Rintel wrote:
> Some fixes were done during the conversion:
> 
> Slightly better examples. The original example was for an OMAP serial
> port, which is not even described by this binding, but by
> omap_serial.txt instead.
> 
> Added compatible strings, that were used, byt not documented:
> andestech,uart16550, cavium,octeon-3860-uart, fsl,16550-FIFO64,
> nvidia,tegra186-uart, nvidia,tegra194-uart, nxp,lpc1850-uart,
> opencores,uart16550-rtlsvn105, ralink,mt7620a-uart, ralink,rt3052-uart,
> ralink,rt3883-uart and xlnx,xps-uart16550-2.00.b.
> 
> Removed "serial" compatible string. It's redundant with the node name
> (which, in OFW, serves the same purpose as the compatible string).
> 
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> 
> ---
> Changes since v1, addressing review from Rob Herring [1]:
> - Utilize anyOf: instead of allOf: to express mutual exclusivity of
>   clock-frequency and clocks.
> - Allow ns16550a where ns16550 is used but actually has a working FIFO;
>   add a comment about ns16550a being preferred
> - resets: specify maxItems based on actual use, drop description
> - current-speed: add type ref
> - used-by-rtas: add type
> - no-loopback-test: add type, fix a typo in description
> - fifo-size: add type ref
> - auto-flow-control: add type
> - tx-threshold: add type ref
> - {rts,cts,dtr,dsr,rng,dcd}-gpios: drop description, redundant to
>   serial.yaml
> 
> [1] https://lore.kernel.org/lkml/CAL_Jsq+GDnYviCdszhghhEVB55giPHk8N9w_KASPXG_=H+ZQig@mail.gmail.com/
> 
>  .../devicetree/bindings/serial/8250.txt       | 102 --------
>  .../devicetree/bindings/serial/8250.yaml      | 223 ++++++++++++++++++
>  2 files changed, 223 insertions(+), 102 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/serial/8250.txt
>  create mode 100644 Documentation/devicetree/bindings/serial/8250.yaml
> 

Applied, thanks.

Rob