linux-kernel - Re: [PATCH] drm/radeon: cleanup coding style a bit

Open Source and information security mailing list archives

Message-ID: <CADnq5_M-pZoFXeeULweXGkzDEvbBjoKm1ZBqAwn0S3J7iM18TA@mail.gmail.com>
Date:   Thu, 30 Apr 2020 10:53:35 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian König <christian.koenig@....com>
Cc:     Bernard Zhao <bernard@...o.com>,
        Alex Deucher <alexander.deucher@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>, opensource.kernel@...o.com
Subject: Re: [PATCH] drm/radeon: cleanup coding style a bit

Applied.  Thanks!

Alex

On Sun, Apr 26, 2020 at 9:18 AM Christian König
<christian.koenig@....com> wrote:
>
> Am 26.04.20 um 15:12 schrieb Bernard Zhao:
> > Maybe no need to check ws before kmalloc, kmalloc will check
> > itself, kmalloc`s logic is if ptr is NULL, kmalloc will just
> > return
> >
> > Signed-off-by: Bernard Zhao <bernard@...o.com>
>
> Reviewed-by: Christian König <christian.koenig@....com>
>
> I'm wondering why the automated scripts haven't found that one before.
>
> > ---
> >   drivers/gpu/drm/radeon/atom.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c
> > index 2c27627b6659..f15b20da5315 100644
> > --- a/drivers/gpu/drm/radeon/atom.c
> > +++ b/drivers/gpu/drm/radeon/atom.c
> > @@ -1211,8 +1211,7 @@ static int atom_execute_table_locked(struct atom_context *ctx, int index, uint32
> >       SDEBUG("<<\n");
> >
> >   free:
> > -     if (ws)
> > -             kfree(ectx.ws);
> > +     kfree(ectx.ws);
> >       return ret;
> >   }
> >
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives