linux-kernel - Re: [PATCH v3 3/4] gpio: thunderx: Utilize for_each_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200430162246.GB7107@syed>
Date:   Thu, 30 Apr 2020 21:52:46 +0530
From:   Syed Nayyar Waris <syednwaris@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     akpm@...ux-foundation.org, vilhelm.gray@...il.com,
        rrichter@...vell.com, linus.walleij@...aro.org,
        bgolaszewski@...libre.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] gpio: thunderx: Utilize for_each_set_clump macro

On Wed, Apr 29, 2020 at 01:17:42PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 29, 2020 at 04:37:41AM +0530, Syed Nayyar Waris wrote:
> > This patch reimplements the thunderx_gpio_set_multiple function in
> > drivers/gpio/gpio-thunderx.c to use the new for_each_set_clump macro.
> > Instead of looping for each bank in thunderx_gpio_set_multiple
> > function, now we can skip bank which is not set and save cycles.
> 
> > +	const unsigned long bank_size = 64;
> 
> Shouldn't be rather definition?

Thanks. I think you mean macro definition. I will incorporate this in my
next version.

> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>