linux-kernel - Re: [PATCH v3 12/12] perf test: improve pmu event metric testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49698917-cdc0-52d5-9c08-ba82f8438657@huawei.com>
Date:   Thu, 30 Apr 2020 18:53:28 +0100
From:   John Garry <john.garry@...wei.com>
To:     Ian Rogers <irogers@...gle.com>
CC:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Haiyan Song <haiyanx.song@...el.com>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Song Liu <songliubraving@...com>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        Leo Yan <leo.yan@...aro.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Paul Clarke <pc@...ibm.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kajoljain <kjain@...ux.ibm.com>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v3 12/12] perf test: improve pmu event metric testing

On 30/04/2020 15:31, Ian Rogers wrote:
> On Thu, Apr 30, 2020 at 4:44 AM John Garry <john.garry@...wei.com> wrote:
>>
>> On 30/04/2020 08:51, Ian Rogers wrote:
>>> Add a basic floating point number test to expr.
>>> Break pmu-events test into 2 and add a test to verify that all pmu metric
>>> expressions simply parse.
>>
>> Could we add also add something in jevents to ensure this?
> 
> I think it is an interesting possibility. Instead of strings we could
> also parse the metrics into C functions, that could cause build time
> errors at least for the simple expressions. An issue I've faced is
> that if jevents fails, such as a json parse error, it has an exit code
> of 0 and creates an empty map file. This allows the build to proceed
> but with the pmu-events functionality broken. I'd prefer a build to
> fail as early as possible.

Yeah, the idea is to allow perf to continue to build even when we have 
broken JSONs, but without aliases. It's been that way since day one, so 
maybe that can be turned off now.

Thanks,
John