linux-kernel - Re: [RFC PATCH v11 6/9] media: tegra: Add Tegra210 Video input driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Apr 2020 12:27:52 -0700
From:   Sowjanya Komatineni <skomatineni@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>, <thierry.reding@...il.com>,
        <jonathanh@...dia.com>, <frankc@...dia.com>, <hverkuil@...all.nl>,
        <sakari.ailus@....fi>, <helen.koike@...labora.com>
CC:     <sboyd@...nel.org>, <linux-media@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v11 6/9] media: tegra: Add Tegra210 Video input driver


On 4/30/20 6:34 AM, Dmitry Osipenko wrote:
> 30.04.2020 01:00, Sowjanya Komatineni пишет:
>> +static int tegra_csi_init(struct host1x_client *client)
>> +{
>> +	struct tegra_csi *csi = host1x_client_to_csi(client);
>> +	struct tegra_video_device *vid = dev_get_drvdata(client->host);
>> +	int ret;
>> +
>> +	INIT_LIST_HEAD(&csi->csi_chans);
>> +
>> +	ret = tegra_csi_tpg_channels_alloc(csi);
>> +	if (ret < 0) {
>> +		dev_err(csi->dev,
>> +			"failed to allocate tpg channels: %d\n", ret);
>> +		goto cleanup;
>> +	}
>> +
>> +	ret = tegra_csi_channels_init(csi);
>> +	if (ret < 0)
>> +		goto cleanup;
>> +
>> +	vid->csi = csi;
>> +
>> +	return 0;
>> +
>> +cleanup:
>> +	tegra_csi_channels_cleanup(csi);
>> +	pm_runtime_put_sync(csi->dev);
> This pm_runtime_put_sync() should be removed.

Sorry, I had it correct in follow-up patches and missed this to remove 
in v12.

Will double check all changes before sending v12 once all v11 feedback 
from you is done.

>
>> +	return ret;
>> +}