lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Apr 2020 12:38:02 -0700 From: Joe Perches <joe@...ches.com> To: Ard Biesheuvel <ardb@...nel.org> Cc: Arvind Sankar <nivedita@...m.mit.edu>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-efi <linux-efi@...r.kernel.org>, X86 ML <x86@...nel.org> Subject: Re: [PATCH 1/2] efi/libstub: efi_info/efi_err message neatening On Thu, 2020-04-30 at 21:29 +0200, Ard Biesheuvel wrote: > On Thu, 30 Apr 2020 at 21:12, Joe Perches <joe@...ches.com> wrote: > > Use a standard style for these output logging messages. > > > > Miscellanea: > > > > o Use more common macro #defines with fmt, ##__VA_ARGS__ > > 0 Remove trailing messages periods and odd ' uses > > o Remove embedded function names and use %s, __func__ > > > > Signed-off-by: Joe Perches <joe@...ches.com> > > --- > > > > Perhaps these trivialities on top of this series? > > > > The EFI printing routines don't actually support format strings. Thanks. Then nevermind on that bit. > Removing trailing periods is not really necessary IMO, but i'll take a > patch that fixes those weird quotes. <shrug> Your choice. There are 60+ uses of efi_err, 12 with a trailing period. cheers, Joe
Powered by blists - more mailing lists