linux-kernel - Re: [PATCH v2 1/2] usb: serial: Add MaxLinear/Exar USB to Serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Apr 2020 08:27:37 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     mani@...nel.org
Cc:     johan@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, patong.mxl@...il.com
Subject: Re: [PATCH v2 1/2] usb: serial: Add MaxLinear/Exar USB to Serial
 driver

On Thu, Apr 30, 2020 at 10:06:35AM +0530, mani@...nel.org wrote:
> +	port_priv->idProduct = le16_to_cpu(serial->dev->descriptor.idProduct);
> +
> +	/* XR21V141X specific settings */
> +	if (port_priv->idProduct == XR21V141X_ID) {
> +		port_priv->regs = &xr21v141x_regs;
> +		port_priv->reg_width = 1;
> +	}

Shouldn't you abort here if idProduct does not have this value, as
that's all you test for everywhere else.  Do you even need to have this
test and save the value everywhere at all?

thanks,

greg k-h