linux-kernel - Re: [PATCH] remoteproc: Fix wrong rvring index computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Apr 2020 08:42:51 +0200
From:   Greg KH <greg@...ah.com>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-remoteproc@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Clement Leger <cleger@...ray.eu>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Evan Green <evgreen@...omium.org>
Subject: Re: [PATCH] remoteproc: Fix wrong rvring index computation

On Wed, Apr 29, 2020 at 04:26:41PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Fri,  4 Oct 2019 Clement Leger <cleger@...ray.eu> wrote:
> >
> > Index of rvring is computed using pointer arithmetic. However, since
> > rvring->rvdev->vring is the base of the vring array, computation
> > of rvring idx should be reversed. It previously lead to writing at negative
> > indices in the resource table.
> >
> > Signed-off-by: Clement Leger <cleger@...ray.eu>
> > ---
> >  drivers/remoteproc/remoteproc_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Randomly stumbled upon this in a list of patches.  This patch landed
> in mainline as:
> 
> 00a0eec59ddb remoteproc: Fix wrong rvring index computation
> 
> Should it be queued up for stable?  I'm guessing:
> 
> Fixes: c0d631570ad5 ("remoteproc: set vring addresses in resource table")

Thanks, now queued up.

greg k-h