linux-kernel - RE: [PATCH] net: ena: fix gcc-4.8 missing-braces warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03f3568ec8c646cdb7c767b16d19525a@EX13D11EUC003.ant.amazon.com>
Date:   Thu, 30 Apr 2020 07:18:47 +0000
From:   "Jubran, Samih" <sameehj@...zon.com>
To:     Arnd Bergmann <arnd@...db.de>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Kiyanovski, Arthur" <akiyano@...zon.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Jesper Dangaard Brouer" <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>
CC:     "Tzalik, Guy" <gtzalik@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: RE: [PATCH] net: ena: fix gcc-4.8 missing-braces warning


> -----Original Message-----
> From: Arnd Bergmann <arnd@...db.de>
> Sent: Wednesday, April 29, 2020 12:51 AM
> To: Belgazal, Netanel <netanel@...zon.com>; Kiyanovski, Arthur
> <akiyano@...zon.com>; David S. Miller <davem@...emloft.net>; Alexei
> Starovoitov <ast@...nel.org>; Daniel Borkmann <daniel@...earbox.net>;
> Jakub Kicinski <kuba@...nel.org>; Jesper Dangaard Brouer
> <hawk@...nel.org>; John Fastabend <john.fastabend@...il.com>; Jubran,
> Samih <sameehj@...zon.com>
> Cc: Arnd Bergmann <arnd@...db.de>; Tzalik, Guy <gtzalik@...zon.com>;
> Bshara, Saeed <saeedb@...zon.com>; Machulsky, Zorik
> <zorik@...zon.com>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; bpf@...r.kernel.org
> Subject: [EXTERNAL] [PATCH] net: ena: fix gcc-4.8 missing-braces warning
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> Older compilers warn about initializers with incorrect curly
> braces:
> 
> drivers/net/ethernet/amazon/ena/ena_netdev.c: In function
> 'ena_xdp_xmit_buff':
> drivers/net/ethernet/amazon/ena/ena_netdev.c:311:2: error: expected ','
> or ';' before 'struct'
>   struct ena_tx_buffer *tx_info;
>   ^~~~~~
> drivers/net/ethernet/amazon/ena/ena_netdev.c:321:2: error: 'tx_info'
> undeclared (first use in this function)
>   tx_info = &xdp_ring->tx_buffer_info[req_id];
>   ^~~~~~~
> drivers/net/ethernet/amazon/ena/ena_netdev.c:321:2: note: each
> undeclared identifier is reported only once for each function it appears in
> 
> Use the GNU empty initializer extension to avoid this.
> 
> Fixes: 31aa9857f173 ("net: ena: enable negotiating larger Rx ring size")
Please use the correct fixes, it should be XDP TX commit.
Otherwise looks good,
Thanks!
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 2cc765df8da3..ad385652ca24 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -307,7 +307,7 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
>                              struct ena_rx_buffer *rx_info)  {
>         struct ena_adapter *adapter = netdev_priv(dev);
> -       struct ena_com_tx_ctx ena_tx_ctx = {0};
> +       struct ena_com_tx_ctx ena_tx_ctx = { };
>         struct ena_tx_buffer *tx_info;
>         struct ena_ring *xdp_ring;
>         u16 next_to_use, req_id;
> --
> 2.26.0