linux-kernel - Re: [PATCH v3 5/7] tty: Add NOKERNINFO lflag to termios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200430072022.GI43805@cello>
Date:   Thu, 30 Apr 2020 10:20:22 +0300
From:   Arseny Maslennikov <ar@...msu.ru>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Landley <rob@...dley.net>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Pavel Machek <pavel@....cz>, linux-api@...r.kernel.org,
        "Vladimir D. Seleznev" <vseleznv@...linux.org>
Subject: Re: [PATCH v3 5/7] tty: Add NOKERNINFO lflag to termios

On Thu, Apr 30, 2020 at 08:55:43AM +0200, Jiri Slaby wrote:
> On 30. 04. 20, 8:42, Arseny Maslennikov wrote:
> > The termios lflag is off by default.
> 
> This commit message is too poor. Describing the intended use would help.
> 

I described its use in the last patch of the series, where it actually
gains some use.

I agree, however, that the limited explanation in this commit does not
look helpful at all when looking at e.g. git blame output.

I'll resend a v4 with this commit message improved.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)