linux-kernel - RE: [PATCH v3 1/3] hwrng: cctrng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR08MB2999F52B99066C321837144DE9AA0@AM6PR08MB2999.eurprd08.prod.outlook.com>
Date:   Thu, 30 Apr 2020 07:39:14 +0000
From:   Hadar Gat <Hadar.Gat@....com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     Matt Mackall <mpm@...enic.com>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Stefan Wahren <wahrenst@....net>,
        Zaibo Xu <xuzaibo@...wei.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gilad Ben-Yossef <gilad@...yossef.com>,
        Ofir Drang <Ofir.Drang@....com>, nd <nd@....com>
Subject: RE: [PATCH v3 1/3] hwrng: cctrng - Add dependency on OF


> -----Original Message-----
> From: linux-crypto-owner@...r.kernel.org <linux-crypto-
> owner@...r.kernel.org> On Behalf Of Herbert Xu
> 
> On Tue, Apr 28, 2020 at 12:26:31PM +0000, Hadar Gat wrote:
> >
> > I've set COMPILE_TEST but couldn't see any problem.
> > Would you share what doesn't work?
> 
> I don't have OF in my config.  This driver builds just fine without OF.

Yes, it builds, but it is useless.
In include/linux/of.h there are definitions for of_property_read*() functions  for the case of OF_CONFIG not being defined that simply returns -ENOSYS.

> 
> Cheers,
> --
> Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt